Add Downloader, LeScanner and Network NUI based application#399
Add Downloader, LeScanner and Network NUI based application#399r-bhalotia wants to merge 3 commits intoSamsung:masterfrom
Conversation
dh79pyun
requested review from
SeonahMoon,
chleun-moon,
dh79pyun,
jiung-yu and
wootak-jung
| "miDebuggerServerAddress": ":1234" | ||
| } | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
.vscode directory not required. Removed it.
| { | ||
| String stateMsg = ""; | ||
|
|
||
| switch (e.State) |
There was a problem hiding this comment.
would it be relevant to include the complete set of states (including paused, queued, canceled) to the ones below?
There was a problem hiding this comment.
Thanks for the review. Added all the states.
wootak-jung
left a comment
wootak-jung
left a comment
There was a problem hiding this comment.
Thanks for your patch!
Please review my inline comments.
dr-venkman
left a comment
dr-venkman
left a comment
There was a problem hiding this comment.
Thank you for the commit, please find my comments included.
|
The code seems to be well-written overall. I've left a few comments, so please check them. |
…s, change screenshots
Thanks for the review, I have made the required changes. |
Thanks for the review. |
4 participants
No description provided.